Skip to content

Remove `unsafe_serialization_hash: true` from JsonCache in License model

Problem

Previously, https://gitlab.com/gitlab-org/gitlab/-/issues/354299 and https://gitlab.com/gitlab-org/security/gitlab/-/issues/735 tried to remove the unsafe_serialization_hash: true from JsonCache in the License model. But those changes had unintended side affect that broke multiple E2E tests.

Those changes were then reverted with https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/2672 and !100112 (merged).

Proposal

The initial issue with using unsafe_serialization_hash: true in JsonCache in the License model is present again and needs to be removed again with a different approach.

In order to check if any new changed result in similar E2E failures at least the e2e:package-and-test pipeline job should be triggered manually (see this comment).