Skip to content

[Feature flag] Rollout of `ci_inbound_job_token_scope`

Summary

This issue is to rollout the feature on production, that is currently behind the ci_inbound_job_token_scope feature flag.

Owners

Stakeholders

Expectations

What are we expecting to happen?

There should be a new UI in CI/CD settings where you can add projects to an allowlist that will allow those projects to access the current project.

See the documentation: https://docs.gitlab.com/ee/ci/jobs/ci_job_token.html#configure-cicd-job-token-access

When is the feature viable?

There is a setting that needs to be toggled on a per-project basis:

  1. Enable the setting 
    Project.first.update!(ci_inbound_job_token_scope_enabled: true)

Or just toggle the setting in the UI: https://docs.gitlab.com/ee/ci/jobs/ci_job_token.html#disable-the-inbound-job-token-scope-allowlist

What might happen if this goes wrong?

If there was a bug it would likely cause project access to not behave as documented.

We can toggle the feature off in case of that scenario: Feature.disable(:ci_inbound_job_token_scope)

What can we check for monitoring production after rollouts?

New errors for scope: https://sentry.gitlab.net/gitlab/gitlabcom/?query=is%3Aunresolved+Scope&sort=new

New errors for allowlist: https://sentry.gitlab.net/gitlab/gitlabcom/?query=is%3Aunresolved+Allowlist&sort=new

Grqphql operations:

Rollout Steps

Rollout on non-production environments

  • Ensure that the feature MRs have been deployed to non-production environments.
    • [-] /chatops run auto_deploy status <merge-commit-of-your-feature>
  • Enable the feature globally on non-production environments.
    • /chatops run feature set ci_inbound_job_token_scope true --dev --staging --staging-ref
  • Verify that the feature works as expected. Posting the QA result in this issue is preferable. The best environment to validate the feature in is staging-canary as this is the first environment deployed to. Note you will need to make sure you are configured to use canary as outlined here when accessing the staging environment in order to make sure you are testing appropriately.

Specific rollout on production

  • Ensure that the feature MRs have been deployed to both production and canary.

    • [-] /chatops run auto_deploy status <merge-commit-of-your-feature>

  • If you're using project-actor, you must enable the feature on these entries: /chatops run feature set --project=gitlab-org/gitlab,gitlab-org/gitlab-foss,gitlab-com/www-gitlab-com ci_inbound_job_token_scope true

  • Verify that the feature works on the specific entries. Posting the QA result in this issue is preferable.

Preparation before global rollout

  • Check if the feature flag change needs to be accompanied with a change management issue. Cross link the issue here if it does.
  • Ensure that you or a representative in development can be available for at least 2 hours after feature flag updates in production. If a different developer will be covering, or an exception is needed, please inform the oncall SRE by using the @sre-oncall Slack alias.
  • Ensure that documentation has been updated (More info).
  • Announce on the feature issue an estimated time this will be enabled on GitLab.com.
  • Ensure that any breaking changes have been announced following the release post process to ensure GitLab customers are aware.
  • Notify #support_gitlab-com and your team channel (more guidance when this is necessary in the dev docs).

Global rollout on production

For visibility, all /chatops commands that target production should be executed in the #production slack channel and cross-posted (with the command results) to the responsible team's slack channel (#g_TEAM_NAME).

Release the feature

After the feature has been deemed stable, the clean up should be done as soon as possible to permanently enable the feature and reduce complexity in the codebase.

You can either create a follow-up issue for Feature Flag Cleanup or use the checklist below in this same issue.

  • Create a merge request to remove ci_inbound_job_token_scope feature flag. Ask for review and merge it.
    • Remove all references to the feature flag from the codebase.
    • Remove the YAML definitions for the feature from the repository.
    • Create a changelog entry.
  • Ensure that the cleanup MR has been included in the release package. If the merge request was deployed before the monthly release was tagged, the feature can be officially announced in a release blog post.
    • /chatops run release check <merge-request-url> <milestone>
  • Close the feature issue to indicate the feature will be released in the current milestone.
  • If not already done, clean up the feature flag from all environments by running these chatops command in #production channel:
    • Ensure the cleanup is deployed: /chatops run auto_deploy status <merge-commit-of-your-feature>
    • /chatops run feature delete ci_inbound_job_token_scope --dev --staging --staging-ref --production
  • Close this rollout issue.

Rollback Steps

  • This feature can be disabled by running the following Chatops command:
/chatops run feature set ci_inbound_job_token_scope false
Edited by Allison Browne