Skip to content

sign_in_text not visible when password authentication is disabled

Summary

I'm opening this as a bug just in case, because the login page redesign makes the description field a bit unusable for longer texts, whereas sign_in_text might still be a good alternative place for some of that, IMO (see screenshots below).

Self-managed instances might be using external authentication providers rather than password authentication. When this is disabled, the sign_in_text is not displayed on the login page. With the new login page redesign, this leaves self-hosted instances with no space to provide more detailed text on the login page, as the text above is center-aligned. Maybe this was intentional, but having sign-in text with instructions on how to use external auth providers is still useful.

I think this might help with similar feedback also posted by @njnatale in &8557 (comment 1112267840) on the login redesign.

Steps to reproduce

  1. Start a 15.4 container and obtain its root password
  2. Log in and go to Admin > Settings > General > Sign-in Restriction
  3. Add text to Sign-in text field
  4. Disable Allow password authentication for the web interface
  5. Save Changes
  6. Open the login page in Incognito mode and see the sign-in text is not shown
  7. Re-enable password authentication and see the sign-in text on login page

Example Project

Not applicable

What is the current bug behavior?

Sign-in text (sign_in_text via API) is hidden if only external authentication providers are used.

What is the expected correct behavior?

Users should be able to see the text even if the instance uses other sign-in methods, not GitLab password authentication.

Relevant logs and/or screenshots

Example with both sign_in_text and appearance description configured:

Password enabled Password disabled*
image image

*In practice this would also show buttons for external auth providers e.g. github/google etc.

Output of checks

Default 15.4 container image

Possible fixes

I'd probably start looking somewhere here:
https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/views/layouts/devise.html.haml#L56-57

/cc @jannik_lehmann

As an aside, it's slightly confusing UX that even though they're displayed on the same page:

  • description is in /application/appearance (API) / Settings > Appearance > Sign in/Sign up pages (UI)
  • sign_in_text is in /application/settings (API) / Settings > General > Settings > General > Sign-in Restriction (UI)