Master failure (in dev) due to application_settings exceeding 1600 columns
Sample failure: https://dev.gitlab.org/gitlab/gitlab-ee/-/jobs/6008462
This is similar to gitlab-foss#63825 (closed) that we saw before.
I suspect that this is due to the "Backport EE Schema" migration that adds / removes 30 columns to application_settings
.
Every time we run a migration spec for a migration before the EE backport migration, we drop the 30 columns and then add them back after the test.
We may want to look into @nick.thomas' suggestion in the previous issue:
🤔 I wonder if using thetransaction
strategy for migration specs would work. Postgres respects transactions around DDL statements, and we don't have to support mysql any more, so it might be worth looking into. The question is whether it would continue to use up slots towards that 1600 limit or not.
Note: Parallelism was increased in https://dev.gitlab.org/gitlab/gitlab-ee/merge_requests/1498 as a short-term fix to this issue.