Skip to content

Typo: Kubernetes GKE setup error message shows "property connected" instead of "properly connected"

Summary

When running a GitLab instance that does not have Google authentication properly configured, trying to create a Google GKE cluster will display an information panel. In the panel, the last line says:

Google authentication is not property configured.

property should be properly, so that it reads:

Google authentication is not properly configured.

Steps to reproduce

  1. Run a GitLab instance that does not have Google authentication properly configured.
  2. Create a new project or open an existing one that does not have a Kubernetes cluster added.
  3. In the sidebar, select Operations -> Kubernetes.
  4. Click on Add Kubernetes cluster.
  5. The Create new cluster tab should be selected by default. Click on the Google GKE button.
  6. An information message should show. Verify that the last line says "Google authentication is not property configured".

Example Project

Cannot provide an example project on gitlab.com because it requires a GitLab instance that's not properly configured with Google authentication.

What is the current bug behavior?

The message displayed has a typo and says "property configured".

What is the expected correct behavior?

The message displayed should say "properly configured".

Relevant logs and/or screenshots

Screen_Shot_2019-11-26_at_3.50.47_PM

Output of checks

This bug happens on a local running instance of GitLab without a proper Google authentication configuration.

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:
Proxy:		no
Current User:	daniel
Using RVM:	no
Ruby Version:	2.6.3p62
Gem Version:	3.0.3
Bundler Version:1.17.3
Rake Version:	12.3.3
Redis Version:	5.0.7
Git Version:	2.24.0
Sidekiq Version:5.2.7
Go Version:	go1.13.4 darwin/amd64

GitLab information
Version:	12.6.0-pre
Revision:	28046a19bcc
Directory:	/Users/daniel/Projects/gitlab-development-kit/gitlab
DB Adapter:	PostgreSQL
DB Version:	10.11
URL:		http://0.0.0.0:3000
HTTP Clone URL:	http://0.0.0.0:3000/some-group/some-project.git
SSH Clone URL:	ssh://daniel@localhost:2222/some-group/some-project.git
Elasticsearch:	no
Geo:		no
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers:


GitLab Shell
Version:	10.2.0
Repository storage paths:
  • default: / GitLab Shell path: /Users/daniel/Projects/gitlab-development-kit/gitlab-shell Git: /usr/local/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab subtasks ...

Checking GitLab Shell ...


GitLab Shell: ... GitLab Shell version >= 10.2.0 ? ... OK (10.2.0)
Running /Users/daniel/Projects/gitlab-development-kit/gitlab-shell/bin/check
Internal API available: OK
Redis available via internal API: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Gitaly ...


Gitaly: ... default ... OK


Checking Gitaly ... Finished


Checking Sidekiq ...


Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Checking Incoming Email ...


Incoming Email: ... Reply by email is disabled in config/gitlab.yml


Checking Incoming Email ... Finished


Checking LDAP ...


LDAP: ... LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab App ...


Git configured correctly? ... no
Trying to fix error automatically. ...Success
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... no
Try fixing it:
sudo chmod 700 /Users/daniel/Projects/gitlab-development-kit/gitlab/public/uploads
For more information see:
doc/install/installation.md in section "GitLab"
Please fix the error above and rerun the checks.
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... no
Try fixing it:
Install the init script
For more information see:
doc/install/installation.md in section "Install Init Script"
Please fix the error above and rerun the checks.
Init script up-to-date? ... can't check because of previous errors
Projects have namespace: ...
22/1 ... yes
22/2 ... yes
23/3 ... yes
24/4 ... yes
25/5 ... yes
26/6 ... yes
27/7 ... yes
28/8 ... yes
37/9 ... yes
46/10 ... yes
48/11 ... yes
17/12 ... yes
16/13 ... yes
8/14 ... yes
4/15 ... yes
30/16 ... yes
32/17 ... yes
45/18 ... yes
1/19 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.6.3)
Git version >= 2.22.0 ? ... yes (2.24.0)
Git user has default SSH configuration? ... no
Try fixing it:
mkdir ~/gitlab-check-backup-1574820508
sudo mv /Users/daniel/.ssh/id_rsa ~/gitlab-check-backup-1574820508
sudo mv /Users/daniel/.ssh/id_rsa.pub ~/gitlab-check-backup-1574820508
For more information see:
doc/ssh/README.md in section "SSH on the GitLab server"
Please fix the error above and rerun the checks.
Active users: ... 44
Is authorized keys file accessible? ... yes
Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)


Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished

Possible fixes

Fix the typo in app/views/clusters/clusters/gcp/_gcp_not_configured.html.haml, as well as in all the .po translation strings:

https://gitlab.com/search?group_id=&nav_source=navbar&project_id=278964&repository_ref=master&search=property+configured&search_code=true

Edited by Daniel Tian