Refactor `SystemNotes::IssuableResourceLinksService#issuable_resource_link_added` and pass `resource_link` object
The following discussion from !96937 (merged) should be addressed:
-
@splattael started a discussion: Suggestion (non-blocking) Since
IncidentManagement::IssuableResourceLink#link_type
is anenum
WDYT of passing the resource link object and useresource_link.general?
instead?🤔 def issuable_resource_link_added(resource_link) link_type = resource_link.general? ? 'resource' : link_type.capitalize
Implementation guide
-
Change signature of SystemNotes::IssuableResourceLinksService#issuable_resource_link_added(link_type)
to acceptresource_link
instead:#issuable_resource_link_added(resource_link)
-
Infer link_type
fromresource_link.general?
link_type = resource_link.general? ? 'resource' : link_type.capitalize
-
Pass issuable_resource_link
(instead ofissuable_resource_link.type
) toSystemNoteService.issuable_resource_link_added
inIncidentManagement::IssuableResourceLinks::CreateService
-
Adjust specs
issuable_resource_link_added
which have different signatures
Edited by Peter Leitzen