Remove unnecessary guard clause in `Environment.auto_stop_in=`
Problem
Originally discussed in !97425 (comment 1096198537).
It looks like we're having an unnecessary guard clause in the Environment.auto_stop_in=
. We should always renew the value when a valid parameter is passed.
Proposal
diff --git a/app/models/environment.rb b/app/models/environment.rb
index 4aab4ab8170c..1a92621aa21f 100644
--- a/app/models/environment.rb
+++ b/app/models/environment.rb
@@ -432,7 +432,6 @@ def auto_stop_in=(value)
return unless value
parser = ::Gitlab::Ci::Build::DurationParser.new(value)
- return if parser.seconds_from_now.nil?
self.auto_stop_at = parser.seconds_from_now
end
Edited by Shinya Maeda