Follow-up from "Remove vulnerabilities from batch graphql request"

The following discussion from !96809 (merged) should be addressed:

  • @dpisek started a discussion:

    thought: I think it would be beneficial to add a comment that explains the reason why we mark this as a single request. Maybe including links to related docs:

    • https://docs.gitlab.com/ee/api/graphql/index.html#max-query-complexity
    • https://docs.gitlab.com/ee/development/fe_guide/graphql.html#managing-performance

    We should also capture this in a spec, something simple like ...

        it(`marks the query to be a single request to reduce the query's complexity score`, () => {
          expect(wrapper.vm.$apollo.queries.vulnerabilities.options.context.isSingleRequest).toBe(true);
        });

    ... could be enough 🤔

    But let's tackle this in a follow up @sming-gitlab 👍

Assignee Loading
Time tracking Loading