No merge button in merge-widget
Summary
When visiting a merge-request page the merge-button is missing. Happened after updating from 15.1.2 to 15.3.1, same error after updating to 15.3.2.
It is happening on 2 projects, for every merge-request every time when loading the merge-request page. This 2 projects do not have a pipeline. Other projects are fine.
Maybe related #364726 (closed), but these bugfixes should have been included in 15.2 already.
Steps to reproduce
- Create a merge-request
- Visit the merge-request page
What is the current bug behavior?
No merge button in merge-widget.
What is the expected correct behavior?
A merge button in merge-widget
Relevant logs and/or screenshots
No error in Javascript-console.
The periodic POST-request to https://domain.com/gitlab/api/graphql replies with:
[
{
"data": {
"project": {
"id": "gid://gitlab/Project/123",
"archived": false,
"onlyAllowMergeIfPipelineSucceeds": true,
"mergeRequest": {
"id": "gid://gitlab/MergeRequest/456",
"autoMergeEnabled": false,
"availableAutoMergeStrategies": [],
"commitCount": 3,
"conflicts": false,
"diffHeadSha": "...",
"mergeError": null,
"mergeStatus": "can_be_merged",
"mergeable": false,
"mergeableDiscussionsState": true,
"headPipeline": null,
"shouldBeRebased": false,
"sourceBranchExists": true,
"state": "opened",
"targetBranchExists": true,
"userPermissions": {
"canMerge": true,
"__typename": "MergeRequestPermissions"
},
"draft": false,
"__typename": "MergeRequest"
},
"__typename": "Project"
}
}
}
]The problem is maybe that mergeable = false whereas it is true at other projects where the merge-button is visible.
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Current User: git Using RVM: no Ruby Version: 2.7.5p203 Gem Version: 3.1.6 Bundler Version:2.3.15 Rake Version: 13.0.6 Redis Version: 6.2.7 Sidekiq Version:6.4.0 Go Version: unknown GitLab information Version: 15.3.2 Revision: e5a7085d434 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 12.10 URL: https://redacted/gitlab HTTP Clone URL: https://redacted/gitlab/some-group/some-project.git SSH Clone URL: git@redacted:some-group/some-project.git Using LDAP: yes Using Omniauth: yes Omniauth Providers: GitLab Shell Version: 14.10.0 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 14.10.0 ? ... OK (14.10.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes (cluster/worker) ... 1/1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... Server: ldapmain LDAP authentication... Success LDAP users with access to your GitLab server (only showing the first 100 results) User output sanitized. Found 100 users of 100 limit.
Checking LDAP ... Finished
Checking GitLab App ...
Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Systemd unit files or init script exist? ... skipped (omnibus-gitlab has neither init script nor systemd units) Systemd unit files or init script up-to-date? ... skipped (omnibus-gitlab has neither init script nor systemd units) Projects have namespace: ... 8/4 ... yes 8/6 ... yes 8/8 ... yes 5/10 ... yes 5/12 ... yes 5/14 ... yes 5/15 ... yes 9/19 ... yes 9/21 ... yes 9/23 ... yes 9/25 ... yes 9/29 ... yes 10/32 ... yes 10/34 ... yes 10/36 ... yes 5/38 ... yes 11/40 ... yes 11/42 ... yes 11/44 ... yes 11/46 ... yes 11/48 ... yes 11/50 ... yes 12/52 ... yes 12/54 ... yes 12/56 ... yes 12/58 ... yes 12/60 ... yes 12/62 ... yes 12/64 ... yes 11/65 ... yes 11/67 ... yes 13/69 ... yes 13/71 ... yes 13/73 ... yes 13/75 ... yes 13/77 ... yes 13/79 ... yes 13/81 ... yes 11/83 ... yes 14/85 ... yes 14/87 ... yes 14/89 ... yes 14/91 ... yes 14/93 ... yes 5/102 ... yes 24/104 ... yes 5/108 ... yes 9/110 ... yes 9/111 ... yes 10/114 ... yes 5/117 ... yes 5/118 ... yes 5/119 ... yes 5/120 ... yes 19/122 ... yes 30/123 ... yes 30/124 ... yes 30/125 ... yes 5/126 ... yes 14/127 ... yes 5/128 ... yes 32/129 ... yes 5/133 ... yes 5/134 ... yes Redis version >= 6.0.0? ... yes Ruby version >= 2.7.2 ? ... yes (2.7.5) Git user has default SSH configuration? ... yes Active users: ... 18 Is authorized keys file accessible? ... yes GitLab configured to store new projects in hashed storage? ... yes All projects are in hashed storage? ... yes
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
Possible fixes / Workaround
- Go to Project -> Settings -> General
- Merge requests -> Merge checks
- Disable "Pipelines must succeed"
- Click Button "Save changes"