Skip to content

HandleAssigneesChangeWorker not executing when merge request assignee changes

Summary

When changing assignees on a Merge Request, the MergeRequests::HandleAssigneesChangeWorker is not being executed, which results in no webhook event being sent for change of assignees.

For comparison, I executed the same Steps to Reproduce on self-managed v15.0, and MergeRequests::HandleAssigneesChangeWorker was being executed, and the appropriate webhook was sent.

I can see there was a recent change to this functionality, I'm wondering if this is a regression? !95446 (merged)

Steps to reproduce

  1. Create new project on GitLab.com
  2. Ensure merge request webhook is configured for the Project
  3. Push a change to create new branch and merge request
  4. Change the assignee of the merge request a few times

Example Project

https://gitlab.com/gitlab-silver/tmike/zd320656/zd320656/-/merge_requests/1

What is the current bug behavior?

Webhook is not sent. No match in logs for MergeRequests::HandleAssigneesChangeWorker associated with the project.

What is the expected correct behavior?

MergeRequests::HandleAssigneesChangeWorker executes and webhook is sent on assignee change.

Relevant logs and/or screenshots

See Elasticsearch logs for my example project, where I changed assignees and the appropriate webhook was not sent, and MergeRequests::HandleAssigneesChangeWorker did not appear (internal): https://log.gprd.gitlab.net/goto/b025a440-272a-11ed-8656-f5f2137823ba

Also see Support field notes (internal): https://gitlab.com/gitlab-com/support/fieldnotes/-/issues/275

See the Recent events for the webhook in the example project. The only webhook sent was for MR creation. Screen_Shot_2022-08-29_at_9.40.41_am

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Possible fixes

Edited by Michael Trainor