Render existing GraphQL fields in new details component
Summary
The new GraphQL-only component for rendering both vulnerability and pipeline findings needs to be able to render the existing GraphQL schema for a PipelineSecurityReportFinding
(see https://gitlab.com/-/graphql-explorer for details on the schema):
- assets
- description
- identifiers
- links
- location
- project
- reportType
- scanner
- severity
- state
- title
Note: There is some backend WIP that is going to add more fields to the type mentioned above, but rendering those will be handled in a separate issue.
Visually it should be the same as the current vulnerability details component:
current vulnerability details |
---|
![]() |
Also see the storybook page for a more interactive overview:
- Run
yarn storybook:start
- Go to http://localhost:9002/?path=/story/ee-vulnerabilities-components-vulnerability-details--default
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- David Pisek changed milestone to %15.4
changed milestone to %15.4
- David Pisek set weight to 3
set weight to 3
- David Pisek assigned to @dpisek
assigned to @dpisek
- David Pisek marked this issue as related to #371314 (closed)
marked this issue as related to #371314 (closed)
- David Pisek added to epic &8459 (closed)
added to epic &8459 (closed)
- David Pisek removed the relation with #371314 (closed)
removed the relation with #371314 (closed)
- David Pisek marked this issue as related to #371314 (closed)
marked this issue as related to #371314 (closed)
- David Pisek set weight to 5
set weight to 5
- Author Maintainer
Collapse replies - Contributor
@dpisek thanks for the ping, let me know if you need me to prioritize anything specifically for this.
1 - Author Maintainer
Awesome @jschafer , thanks!
FYI - This issue covers the existing schema fields and I think together with #371314 (closed) will be enough for %15.4.
That would give us this milestone to add more fields, and we can then put in the related frontend work to render the added data in %15.5. Sounds like a plan?
🙂
- David Pisek mentioned in merge request !96233 (merged)
mentioned in merge request !96233 (merged)
- David Pisek added workflowin dev label and removed workflowplanning breakdown label
added workflowin dev label and removed workflowplanning breakdown label
- David Pisek added #372102 (closed) as child task
added #372102 (closed) as child task
- David Pisek added #372105 (closed) as child task
added #372105 (closed) as child task
- David Pisek created branch
371722-pipeline-sec-graphql-migration-render-severity-field
to address this issuecreated branch
371722-pipeline-sec-graphql-migration-render-severity-field
to address this issue - David Pisek mentioned in merge request !96546 (merged)
mentioned in merge request !96546 (merged)
- David Pisek added #372209 (closed) as child task
added #372209 (closed) as child task
- David Pisek mentioned in merge request !97027 (closed)
mentioned in merge request !97027 (closed)
- David Pisek mentioned in merge request !97028 (merged)
mentioned in merge request !97028 (merged)
- Phil Calder added devopsgovern label and removed devopssecure label
added devopsgovern label and removed devopssecure label
- David Pisek changed the description
Compare with previous version changed the description
- David Pisek added #373865 (closed) as child task
added #373865 (closed) as child task
- David Pisek added #373866 (closed) as child task
added #373866 (closed) as child task
- David Pisek added #373867 as child task
added #373867 as child task
- David Pisek added #373868 as child task
added #373868 as child task
- David Pisek added #373869 as child task
added #373869 as child task
- David Pisek added #373870 (closed) as child task
added #373870 (closed) as child task
- David Pisek added #373871 (closed) as child task
added #373871 (closed) as child task
- David Pisek added #373872 (closed) as child task
added #373872 (closed) as child task
- David Pisek added #373873 (closed) as child task
added #373873 (closed) as child task
- David Pisek added #373874 (closed) as child task
added #373874 (closed) as child task
- David Pisek added #373875 as child task
added #373875 as child task
- David Pisek added #373876 (closed) as child task
added #373876 (closed) as child task
- David Pisek added #373877 (closed) as child task
added #373877 (closed) as child task
- David Pisek created branch
371722-pipeline-sec-graphql-migration-render-existing-graphql-location-to-new-details-component
to address this issuecreated branch
371722-pipeline-sec-graphql-migration-render-existing-graphql-location-to-new-details-component
to address this issue - David Pisek mentioned in merge request !97991 (merged)
mentioned in merge request !97991 (merged)
- David Pisek marked the checklist item location as completed
marked the checklist item location as completed
- David Pisek marked the checklist item title as completed
marked the checklist item title as completed
- 🤖 GitLab Bot 🤖 changed milestone to %15.5
changed milestone to %15.5
- 🤖 GitLab Bot 🤖 added missed:15.4 label
added missed:15.4 label
- David Pisek created branch
371722-pipeline-sec-graphql-migration-render-report-type-in-new-details-component
to address this issuecreated branch
371722-pipeline-sec-graphql-migration-render-report-type-in-new-details-component
to address this issue - David Pisek mentioned in merge request !98668 (merged)
mentioned in merge request !98668 (merged)
- David Pisek marked the checklist item reportType as completed
marked the checklist item reportType as completed
- David Pisek created branch
371722-pipeline-sec-graphql-migration-render-links-field-in-new-details-component
to address this issuecreated branch
371722-pipeline-sec-graphql-migration-render-links-field-in-new-details-component
to address this issue - David Pisek mentioned in merge request !99140 (merged)
mentioned in merge request !99140 (merged)
- David Pisek created branch
371722-pipeline-sec-graphql-migration-render-scanner-field-in-new-details-component
to address this issuecreated branch
371722-pipeline-sec-graphql-migration-render-scanner-field-in-new-details-component
to address this issue - David Pisek changed the description
Compare with previous version changed the description
- David Pisek removed child task #373867
removed child task #373867
- David Pisek created branch
371722-pipeline-sec-graphql-migration-render-identifiers-field-in-new-details-component
to address this issuecreated branch
371722-pipeline-sec-graphql-migration-render-identifiers-field-in-new-details-component
to address this issue - David Pisek marked the checklist item links as completed
marked the checklist item links as completed
- David Pisek mentioned in epic &8910 (closed)
mentioned in epic &8910 (closed)
- David Pisek mentioned in merge request !100254 (merged)
mentioned in merge request !100254 (merged)
- David Pisek changed epic to &8910 (closed)
changed epic to &8910 (closed)
- David Pisek removed the relation with #371314 (closed)
removed the relation with #371314 (closed)
- David Pisek changed title from [Pipeline Sec - GraphQL migration]: Render existing GraphQL fields in new details component to Render existing GraphQL fields in new details component
changed title from [Pipeline Sec - GraphQL migration]: Render existing GraphQL fields in new details component to Render existing GraphQL fields in new details component
- David Pisek marked the checklist item identifiers as completed
marked the checklist item identifiers as completed
- David Pisek created branch
371722-render-state-in-new-details-component
to address this issuecreated branch
371722-render-state-in-new-details-component
to address this issue - David Pisek mentioned in merge request !100594 (merged)
mentioned in merge request !100594 (merged)
- 🤖 GitLab Bot 🤖 changed milestone to %15.6
changed milestone to %15.6
- 🤖 GitLab Bot 🤖 added missed:15.5 label
added missed:15.5 label
- David Pisek marked the checklist item state as completed
marked the checklist item state as completed
- 🤖 GitLab Bot 🤖 mentioned in issue gl-retrospectives/govern/threat-insights#27
mentioned in issue gl-retrospectives/govern/threat-insights#27
- David Pisek mentioned in merge request !101912 (merged)
mentioned in merge request !101912 (merged)
- Developer
@dpisek it looks like this should now be workflowin review ?
Collapse replies - Developer
@dpisek I added
On Track
for the health status. I think we should consider moving the remaining tasks to a new issue so we don't have multi-milestone issues. WDYT? - Author Maintainer
Thanks for the suggestion @nmccorrison - I agree that breaking out the remaining tasks and capture them in their own issues makes sense.
I've created the following issues:
-
#382203 (closed): Render evidence fields within the new GraphQL vulnerability details component
-
#382204 (closed): Render false-positive alert within the new GraphQL vulnerability details component
-
#382205 (closed): Render solution card within the new GraphQL vulnerability details component
Given that, I'll close this issue
👍 -
- Developer
Sweet. Thanks @dpisek. I put labels on them to appease the bot.
- Author Maintainer
Thanks for that @nmccorrison ! I didn't get to finish refining them yesterday, hence the missing labels.
FYI - #382203 (closed) ended up on the bigger side, so I am leaning towards breaking it up even more.
- Developer
Thanks @dpisek. It's good to hear this exercise may have uncovered another opportunity to break the work up.
- Neil McCorrison added Track Health Status [DEPRECATED] label
added Track Health Status [DEPRECATED] label
- Neil McCorrison changed health status to on track
changed health status to on track
- David Pisek marked the checklist item scanner as completed
marked the checklist item scanner as completed
- David Pisek created branch
371722-render-assets-in-new-details-component
to address this issuecreated branch
371722-render-assets-in-new-details-component
to address this issue - Neil McCorrison added Threat InsightsNavy label
added Threat InsightsNavy label
- David Pisek mentioned in merge request !103592 (merged)
mentioned in merge request !103592 (merged)
- David Pisek changed the description
Compare with previous version changed the description
- David Pisek marked the checklist item assets as completed
marked the checklist item assets as completed
- David Pisek changed the description
Compare with previous version changed the description
- David Pisek removed child task #373875
removed child task #373875
- David Pisek removed child task #373868
removed child task #373868
- David Pisek removed child task #373869
removed child task #373869
- David Pisek closed
closed
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#9967 (closed)
mentioned in issue gitlab-org/quality/triage-reports#9967 (closed)
- David Pisek added workflowproduction label and removed workflowin dev label
added workflowproduction label and removed workflowin dev label