Skip to content

UI issue and console errors for manually created vulnerabilities

Summary

When creating a vulnerability manually a Vue component tries to access a non-existing property on an object, which throws an error. This results in a broken UI and console errors (see screenshots below).

Steps to reproduce

  1. Go to a project's "Security & Compliance" -> "Vulnerability Report"
  2. Click on the "+ Submit vulnerability" button
  3. Fill out details and submit
  4. After being redirected to the newly submitted vulnerability's details page open your devtools
  5. Check for errors (see screenshot below)
  6. Check for the broken UI (see screenshot below)

Example Project

Manually created vulnerability:

https://gitlab.com/gitlab-org/secure/tests/vuln-dismiss-test/-/security/vulnerabilities/54006061

What is the current bug behavior?

  • Console errors from Vue component
  • Partly broken UI

What is the expected correct behavior?

  • No console errors
  • The UI is working as expected

Relevant logs and/or screenshots

description screenshot
console errors Screen_Shot_2022-08-10_at_4.19.19_pm
UI Screen_Shot_2022-08-10_at_4.19.50_pm

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

See https://gitlab.com/gitlab-org/gitlab/-/compare/master...370369-ui-issue-and-console-errors-for-manually-created-vulnerabilities

Edited by David Pisek