An error occurred while fetching the assigned iteration of the selected issue.
Don't create group link audit events when there is no change
Problem to solve
Right now audit events are created to whenever certain APIs are called. This is great for maintaining visibility whenever actions take place. However, it means that audit events are always created, even when no change has occurred. This can cause the audit log to be filled with events that aren't meaningful. See the screenshot on the epic for an example where no actual changed occurred, yet an event was created.
The audit event located in the
EE::Projects::GroupLinks::UpdateService
likely exhibits this
behavior
Proposal
When an audit event is about to be created, check that there actually was a change. If there was, create the event if normal. However, if no change actually occurred, do not create an audit event.
-
add a spec for
EE::Projects::GroupLinks::UpdateService
to check against the described behavior - if the spec fails, make it pass