Vulnerability Report: Activity filter menu changes
Why are we doing this work
The Activity
menu on our Vulnerability Report is confusing with the how All Activity
, No Activity
, With issues
, and No longer detected
are seemingly tied together.
This issue is to rewrite the menu so that each filter group is an independent OR condition.
- User can select options from as many groups as they wish.
- User can select only one option from each group (eg: either
Still detected
orNo longer detected
can be checked, but not both). - Clicking a selected option will deselect and remove that group from the query.
- Unselecting all options will reset the default with
All Activity
checked. - Clicking
All Activity
will reset and uncheck all options.
backend confirmed the current GraphQL query supports the parameters and structure we need. See &7883 (comment 954189436)
Currently supported filters:
- Detection
- Still detected
- No longer detected
- Issue
- Has issue
- Does not have issue
- MR
- Has MR
- Does not have MR
- Solution Available
- Is available
- Is not available
- False Positive
- Is a false positive
- Is not a false positive
Relevant links
Non-functional requirements
-
Documentation: -
Feature flag: -
Performance: -
Testing:
Implementation plan
The current API supports the following features for filtering:
Backend supports | Feature | Filter |
---|---|---|
Available | Detection | state |
Available | Issue | hasIssues |
#371313 (closed) | MR | - |
#358638 (closed) | Solution Available | - |
N/A | False positive | - |
Available | Auto Resolved | hasResolution |
N/A | Auto Dismissed | - |
Based on this table, we should implement whatever is implementable.
-
Modify https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/assets/javascripts/security_dashboard/components/shared/filters/activity_filter.vue to match the design
E2E testing
This involves front end and backend changes for activity filter. Calls for adding at least one E2E test.
Verification steps
Edited by Harsha Muralidhar