Skip to content

UI in groups with a group with longer name is broken

Summary

UI in groups with a group with longer name is broken on mobile.

What is the current bug behavior?

The title of a group with longer group name has too wide line-height of 42px.

What is the expected correct behavior?

The title of a group with longer group name should not have any specific line-height.

Relevant logs and/or screenshots

For example:

before

Output of checks

This bug happens on GitLab.com (15.3-pre).

Possible fixes

Remove the (shared) CSS selector one every occurrence is addressed.

$ git grep 'no-description'
app/assets/stylesheets/framework/lists.scss:    &.no-description {
app/assets/stylesheets/pages/projects.scss:    &.no-description {
app/views/admin/groups/_group.html.haml:- css_class = "gl-display-flex!#{' no-description' if group.description.blank?}"
app/views/admin/projects/_projects.html.haml:        %li.project-row{ class: ('no-description' if project.description.blank?) }
app/views/groups/projects.html.haml:      %li.project-row{ class: ('no-description' if project.description.blank?) }
app/views/shared/groups/_group.html.haml:%li.group-row.py-3.gl-align-items-center{ class: "gl-display-flex!#{' no-description' if group.description.blank?}" }
app/views/shared/projects/_project.html.haml:- css_class += " no-description" if project.description.blank? && !show_last_commit_as_description
Edited by Takuya Noguchi