Design view: Flashes/warnings are not visible
Summary
When viewing a design, flashes/alerts are not visible. This is because they do not appear in the design, and rather the issue itself (behind the overlay).
Steps to reproduce
- Click on a design to open the overlay
- Trigger some kind of error (perhaps manually)
- Observe - there will be no flash present. Observing the DOM, however, the flash is being triggered, but it's happening on the main page (in this case, on the issue page
Example Project
GitLab 12.4+
What is the current bug behavior?
If the user experiences an error when viewing a design, they get no feedback (via a flash)
What is the expected correct behavior?
If the user experiences an error when viewing a design, they should get feedback (via a flash)
Relevant logs and/or screenshots
Scenario: I have triggered an error manually, its message is DesignManagement|TEST ERROR.
When viewing the design:
When closing the design:
Possible fixes
createFlash currently uses the .flash-container to inject the flash element. One approach would be to define a container in this design overlay (e.g. .dm-flash-container), and add an optional argument to the createFlash function that takes a selector for injection. This way other similar overlays throughout GitLab could use the same method.
Designs from @jareko
- The final design is here
- Link to specs are here
