Secure analyzer release pipelines not-blocking release tag

Summary

Something changed recently that caused our analyzer pipelines to not block rollout of the major and latest versions. This can be problematic because it makes the manual trigger useless and prevents proper testing of a versioned release prior to overriding the stable release.

Steps to reproduce

(How one can reproduce the issue - this is very important)

Example Project

https://gitlab.com/gitlab-org/security-products/analyzers/sobelow/-/jobs/356770146

What is the current bug behavior?

build latest and build major are not blocked by build tag manual job

What is the expected correct behavior?

build latest and build major should be blocked by build tag manual job

Relevant logs and/or screenshots

Screen_Shot_2019-11-20_at_14.36.42

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:env:info)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

According to the docs we must apply allow_failure: false for some reason

Assignee Loading
Time tracking Loading