Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 54.9k
    • Issues 54.9k
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1.5k
    • Merge requests 1.5k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #369008
Closed
Open
Issue created Jul 28, 2022 by Bojan Marjanovic@bmarjanovic🔴Maintainer

Integrations leaking emails in WebHook Logs detail page

Summary

While testing integrations' WebHook (DroneCi), I came across that some logs contain multiple commits data (author's email included and not redacted).

Steps to reproduce

  1. Go to the Integrations page of a project
  2. Select an integration with a WebHook (e.g. DroneCi) and test the configuration
  3. Click on View details of the webhook created
  4. Scroll down to the request part and validate that emails are visible

What is the current bug behavior?

Committers' emails are visible

What is the expected correct behavior?

The emails should be redacted

Relevant logs and/or screenshots

image

[Image redacted]

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

Update the redact_author_email method with the code bellow

def redact_author_email
  self.request_data.deep_transform_values! do |value|
    value =~ URI::MailTo::EMAIL_REGEXP ? _('[REDACTED]') : value
  end
end

/cc @arturoherrero as the EM

Edited Nov 14, 2022 by Nick Malcolm
Assignee
Assign to
Time tracking