Investigate vulnerability: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal') in tar

Issue created from vulnerability:

  • https://gitlab.com/gitlab-org/gitlab/-/security/vulnerabilities/35332742 CVE-2021-32804 in tar:6.0.5 via compression-webpack-plugin:5.0.2 in yarn.lock

Also applicable:

  • https://gitlab.com/gitlab-org/gitlab/-/security/vulnerabilities/35332741 CVE-2021-32803 in tar:6.1.0 via @storybook/addon-essentials:6.2.9 in storybook/yarn.lock
  • https://gitlab.com/gitlab-org/gitlab/-/security/vulnerabilities/35332740 CVE-2021-32803 in tar:6.0.5 via compression-webpack-plugin:5.0.2 in yarn.lock
  • https://gitlab.com/gitlab-org/gitlab/-/security/vulnerabilities/35332735 CVE-2021-32804 in tar:6.1.0 via @storybook/addon-essentials:6.2.9 in storybook/yarn.lock
  • https://gitlab.com/gitlab-org/gitlab/-/security/vulnerabilities/22571304 CVE-2021-37712 in tar:6.0.5 via compression-webpack-plugin:5.0.2 in yarn.lock
  • https://gitlab.com/gitlab-org/gitlab/-/security/vulnerabilities/22571303 CVE-2021-37713 in tar:6.0.5 via compression-webpack-plugin:5.0.2 in yarn.lock
  • https://gitlab.com/gitlab-org/gitlab/-/security/vulnerabilities/22571301 CVE-2021-37712 in tar:6.1.0 via @storybook/addon-essentials:6.2.9 in storybook/yarn.lock
  • https://gitlab.com/gitlab-org/gitlab/-/security/vulnerabilities/22571300 CVE-2021-37713 in tar:6.1.0 via @storybook/addon-essentials:6.2.9 in storybook/yarn.lock
  • https://gitlab.com/gitlab-org/gitlab/-/security/vulnerabilities/20641599 CVE-2021-37701 in tar:6.1.0 via @storybook/addon-essentials:6.2.9 in storybook/yarn.lock

Looks like 6.1.9+ will address it, and 6.1.11 is the latest: https://www.npmjs.com/package/tar?activeTab=versions

@cdybenko / @leipert is this something your team can investigate please? We'd potentially address eight vulnerable dependency alerts in one go!

  • Decide whether this impacts GitLab and therefore needs to follow the security process
    • compression-webpack-plugin looks like a runtime / non-dev dependency: https://gitlab.com/gitlab-org/gitlab/-/blob/master/package.json#L103
    • storybook is a dev dependency: https://gitlab.com/gitlab-org/gitlab/-/blob/master/storybook/package.json
  • If GitLab isn't impacted we can also downgrade the severity. I'll set as severity2 given the "High" rating for now
  • Can we update tar directly, or do we need to update all its individual upstream dependencies?

Description:

The npm package "tar" (aka node-tar) before versions 6.1.1, 5.0.6, 4.4.14, and 3.3.2 has a arbitrary File Creation/Overwrite vulnerability due to insufficient absolute path sanitization. node-tar aims to prevent extraction of absolute file paths by turning absolute paths into relative paths when the preservePaths flag is not set to true. This is achieved by stripping the absolute path root from any absolute file paths contained in a tar file. For example /home/user/.bashrc would turn into home/user/.bashrc. This logic was insufficient when file paths contained repeated path roots such as ////home/user/.bashrc. node-tar would only strip a single path root from such paths. When given an absolute file path with repeating path roots, the resulting path (e.g. ///home/user/.bashrc) would still resolve to an absolute path, thus allowing arbitrary file creation and overwrite. This issue was addressed in releases 3.2.2, 4.4.14, 5.0.6 and 6.1.1. Users may work around this vulnerability without upgrading by creating a custom onentry method which sanitizes the entry.path or a filter method which removes entries with absolute paths. See referenced GitHub Advisory for details. Be aware of CVE-2021-32803 which fixes a similar bug in later versions of tar.

  • Severity: high
  • Confidence: unknown
  • Location: yarn.lock

Solution:

Upgrade to versions 3.2.2, 4.4.14, 5.0.6, 6.1.1 or above.

Identifiers:

  • Gemnasium-8d63f9f1-0a88-4f8d-b423-48892f01c709
  • CVE-2021-32804
  • GHSA-3jfq-g458-7qm9

Links:

  • https://github.com/advisories/GHSA-3jfq-g458-7qm9
  • https://github.com/npm/node-tar/commit/1f036ca23f64a547bdd6c79c1a44bc62e8115da4
  • https://github.com/npm/node-tar/security/advisories/GHSA-3jfq-g458-7qm9
  • https://nvd.nist.gov/vuln/detail/CVE-2021-32804
  • https://www.npmjs.com/advisories/1770
  • https://www.npmjs.com/package/tar
  • https://www.oracle.com/security-alerts/cpuoct2021.html

Scanner:

  • Name: Gemnasium
Edited Jul 26, 2022 by Lukas Eipert
Assignee Loading
Time tracking Loading