Service Desk email display name text box is not visible on Settings -> General -> Service Desk

Summary

After configuring incoming email, when trying to use a custom email display name for Service Desk, there is no textbox in the UI on Settings - General - Service Desk. The issue is only happening in self-managed GitLab instances.

It looks like this feature is (now) dependent on the custom Service Desk inbox being configured:

Looks like this was introduced in c9a40be0 and the fix is just to remove the v-if="hasProjectKeySupport" that was added to the component there (along with thorough testing).

The workaround is simply to configure the custom mailbox.

Steps to reproduce

1. Set up incoming email for GitLab instance
2. Activate Service Desk
3. Go to Settings -> General -> Service Desk to customize email display name. There is no textbox to be able to input display name.

Example Project

What is the current bug behavior?

Settings -> General -> Service Desk does not have a textbox to enter custom Service Desk email display name.

What is the expected correct behavior?

Settings -> General -> Service Desk should have a textbox to enter custom Service Desk email display name.

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

System information
System:		Ubuntu 20.04
Proxy:		no
Current User:	git
Using RVM:	no
Ruby Version:	2.7.5p203
Gem Version:	3.1.4
Bundler Version:2.1.4
Rake Version:	13.0.6
Redis Version:	6.2.6
Sidekiq Version:6.4.0
Go Version:	unknown

GitLab information
Version:	14.8.1-ee
Revision:	70ab23e7cf3
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	PostgreSQL
DB Version:	12.7
URL:		https://gitlab-gcp.supermunn.com
HTTP Clone URL:	https://gitlab-gcp.supermunn.com/some-group/some-project.git
SSH Clone URL:	git@gitlab-gcp.supermunn.com:some-group/some-project.git
Elasticsearch:	no
Geo:		no
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers: 

GitLab Shell
Version:	13.23.2
Repository storage paths:
- default: 	/var/opt/gitlab/git-data/repositories
GitLab Shell path:		/opt/gitlab/embedded/service/gitlab-shell

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Also happening on 15.0.0

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)
(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)
(we will only investigate if the tests are passing)

Possible fixes

Adding the records directly to the database for given project(s).

1. Open psql session:

sudo gitlab-psql -d gitlabhq_production

OR

sudo gitlab-rails dbconsole --database main

2. Run:

insert into service_desk_settings(project_id, outgoing_name) values(<PROJECT_ID>, 'Test SD Support Bot');
insert into service_desk_settings(project_id, outgoing_name) values(<PROJECT_ID>, 'Test SD Support Bot');