Wrap around the helm command in scripts/review_apps/review-apps.sh

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

Because we need to run a number of helm commands and some of them share a lot of command line options. It'll be easier to maintain if we wrap around the command.

We can perhaps rewrite it in Ruby so it'll be easier to do this. It can help us avoid the mistake at !19858 (comment 247000518)

---

The following discussion from !20366 (merged) should be addressed:

• @godfat started a discussion: (+2 comments)

  I am guessing that we don't need to pass the namespace for helm dependency build . nor helm repo add gitlab https://charts.gitlab.io (3 lines above this line).

  I started to wonder though, does it make sense if we wrap around the helm command like we did in lib/quality/helm_client.rb? I see it's difficult to do this in a shell script, but perhaps at some point we should move all these to a Ruby script?