[MR Widget V2]: Handle action buttons

added to epic &8353 (closed)

@svedova, please add a type label and a subtype label to this issue to help with better milestone planning and issue discovery in issue reports.

(improve this comment?)

added auto updated label

changed milestone to %15.3

added Category:Vulnerability Management devopssecure frontend groupthreat insights merge request widget sectiondev typemaintenance workflowin review labels

changed milestone to %15.4

added workflowready for development label and removed workflowin review label

changed the description

added 1 deleted label

set weight to 3

added workflowrefinement label and removed workflowready for development label

@dpisek can you please double check this issue and see if anything is unclear? I've added a weight of 3 but please feel free to modify as you see fit. Once you're done, please update the label to workflowready for development

Thanks @svedova

Just to clarify - the action buttons are the buttons on the right of the widget's title (excluding the toggler). For example:

And the outcome of this issue should be that all buttons render as captured in the description's image, but are not wired up yet?

If that is correct then I think a 3 feels like a good estimate!

@dpisek that's correct!

assigned to @dpisek

Adding workflowready for development label and unassigning @dpisek so that this issue results free to take.

added workflowready for development label and removed workflowrefinement label

unassigned @dpisek

added ready to pull label and removed 1 deleted label

added [deprecated] Accepting merge requests label

mentioned in issue gitlab-org/quality/triage-reports#8848 (closed)

marked the checklist item Note: The action buttons does not contain the Toggler on the mostright of the widget. That work will be captured here: #368613 (closed) as completed

I'm picking this up

Here's the MR: !95924 (merged)

!95924 (merged) got merged. I tested this locally and it works as expected:

Closing this issue.

assigned to @svedova

@sming-gitlab quick question. I'm aware we redesigned the Security Training banner, so instead of a blue dot button with a popover, we'll display a banner in the details section. However, if we were to implement to blue dot button, do you think the following logic makes sense?

The action buttons would still be passed as a an array of objects (like the extension API today). But anything that is specific to the widget can still be developed inside the summary section. Please take a look at the following image:

Now, the actions part will be populated through the array of objects. But the summary part can extend until where the actions button. Adding there a blue dot and aligning it to most right would create an illusion that it's part of the actions. Does this solution makes sense to you?

@svedova thanks for the ping! Yup, that makes sense to me! I do have a question about the placement of the action items -- what happens when you have multiple widgets that may or may not have a summer section, should the actions be vertical flex-start, so it has a consistent outlook

Not sure if we also need to check in with UX , but looks like that's what they indicated in their mocks, so we should be good

what happens when you have multiple widgets that may or may not have a summer section, should the actions be vertical flex-start, so it has a consistent outlook

@sming-gitlab can you please help me understand better? I didn't get what you mean.