Add value units to VSA "Stage time chart"

Problem to solve

Some users of VSA are unsure if the VSA stage time chart is displaying stage time in days or hours. There are different units in view on the screen and no units on the chart. This is made harder if users can't make the link between values in the path component and individual data points on the chart.

Based on conversation on slack

Haim is "Stage time... Average time to completion" when viewing a custom stage in a VSA report based on days or hours?

I ask because looking at https://gitlab.com/groups/gitlab-org/-/analytics/value_stream_analytics?created_after=2022-06-09&created_before=2022-07-08&value_stream_id=491&stage_id=890&sort=end_event&direction=desc&page=1, the "Ready for Development" button says 2w but the average of all the values on the chart is ~45 (which is not anywhere close to 2 weeks)

It should be days. Looks like we miss the (days) for the Y axis.

average of all the values on the chart is ~45 (which is not anywhere close to 2 weeks) These are differently aggregated metrics

  • 2w is median (top)
  • for each day we aggregate the durations of the finished items (average). (each dot on the chart)

Solution

Make units clearer within the context of the chart.

  1. Add unit (Days) to the chart y-axis title.
  2. Append unit day | days to the popover content.
  3. Remove (Date) from the popover content.
Total time Stage time
Screenshot_2022-07-26_at_14.25.07 Screenshot_2022-07-26_at_14.24.14

I didn't see any formatting guidance in Pajamas for units in charts. In the popover I chose to include the unit in the value of the key:value pair. This mirrors pattern in the path.

Edited by Dan MH