Refactor Environment tracking code in Ci::Build model
Problem
Non-blocker/Suggestion: As @ali-gitlab's pointed out.
Ci::Build#track_verify_usage
, includingcount_user_verification?
, doesn't quite convey the actual intent of the method. For example, this can be interpreted as tracking testing jobs as part of the ~"group::pipeline insights" categories. Especially, this is important in a congested model which is cross-referenced by multiple different domains.I suggest explicitly clarifying the purpose of the method or classifying the methods group, that these are used for ~"group::release" usage. For example, we can refactor
Ci::HasDeploymentName
module toGitlab::Ci::Build::TrackEnvironmentUsage
and maintain thesetrack_deployment_usage
,track_verify_usage
andcount_user_verification?
there.