Group reviewers: require all MRs from a Group be subject to another Group's approval

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Release notes

Users need the ability to assign a specific team of "mentors" to another team. Such that one team requires approval from another team.

  • TeamFoo requires TeamSeniorBar's approval.
  • TeamBar requires TeamSeniorFoo's approval.

Problem to solve

My company has the notion of a Senior Tier of developers. These developers are dispersed amongst development teams. Then we assign the Senior Developers from one team to assess the contribution from a different team they were assigned. They ultimately have to sign off on them.

Assigning reviewers shouldn't require code ownership. Not all companies have embrace the notion of code ownership.

Intended users

Our company doesn't have a single Team Lead. Every senior member shares this role. Every team has one or two senior members. Then every quarter we shift and one team's senior members gets assigned to review/mentor/approve another team's contributions.

User experience goal

Relationships between teams and review-teams become a first-class property in GitLab.

Proposal

If we place every group in GitLab, one for the team Foo and another for team Bar, and one for the correspond Senior Members of Foo, SeniorFoo (and likewise for SeniorBar) we should be able to assign one team SeniorFoo to review all the contributions made by Bar.

  • Group Information -> Contribution Reviewers

It would be nice if we could turn on the Contribution Reviewers for just certain repositories.

Further details

Originally asked on Devops.SE https://devops.stackexchange.com/q/16177/18965

Edited by 🤖 GitLab Bot 🤖