Toggling Edit Button for Labels Select Dropdown for Board Configuration No Longer Closes Dropdown When Open
Summary
When editing a board to organize by labels, and the labels dropdown is already opened within the edit board modal, clicking the edit button again no longer closes the dropdown.
This first appeared as an intermittent failure in our QA test qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/configure_issue_board_by_label_spec.rb
on staging canary on 06/26/2022:
#365368 (closed)
At the time of writing this issue, in https://gitlab.com/gitlab-org/gitlab/-/blob/master/qa/qa/ee/page/component/issue_board/show.rb, the comment on line 41 notes:
# Clicking the edit button again closes the dropdown and allows the save button to be clicked
click_element(:labels_edit_button)
https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/assets/javascripts/boards/components/labels_select.vue#L126 also shows that toggleEdit
should hide the dropdown, but does not appear to be working as expected.
The dropdown can still be closed if you click outside it, or click on the "x" button in the upper right corner.
Steps to reproduce
- In GDK, create a project and visit it
- Go to Issues -> Boards on the sidebar
- Click on "Edit board" button in the top right corner
- In the Edit board modal, next to Labels, click on "Edit"
- With the "Select labels" dropdown open, click on "Edit" again
What is the current bug behavior?
The edit button no longer closes the dropdown as expected.
What is the expected correct behavior?
The edit button should close the dropdown if it is already opened.
Relevant logs and/or screenshots
Screen_Recording_2022-06-15_at_2.19.06_PM
Output of checks
This bug happens on GitLab.com