Skip to content

Free users with service ping data sharing enabled can't update their group IP allowlist

Problem

When the feature flag for IP allowlisting is not globally enabled, the UX experience is confusing. It would be useful to add a note or error message indicating that it is not possible to enter the IP addresses, and deactivate the edit field.

Please see this note for more context: https://gitlab.com/gitlab-com/gl-security/appsec/appsec-team/-/issues/270#note_974557115

Kapture_2022-06-07_at_16.04.21

MVC proposal

  1. Have the field initially disabled globally
  2. Update helper text to explain why its disabled
    • Helper text copy: Editing IP addresses is disabled and can be enabled by a GitLab administrator.
    • There are two scenarios to deal with for informing the user why they can't edit the IP Allowlist
      • Scenario A: The feature to edit IP addresses via UI disabled but the group has IP addresses in list.
      • Scenario B: The feature to edit IP addresses via UI disabled and no IP addresses were ever set.
  3. Enable the field once the associated feature has been enabled for IP Allowlisting
Scenario A: Scenario with IP list Scenario B: Empty scenario
image image
Edited by Michał Wielich