Custom notification events: link in ' To find out more, check out notification emails' lands on a redirect page

Summary

In the custom notification dialogue, the link to the help page about notification emails goes to a redirect page.

Steps to reproduce

  • Click on user profile menu top right, select settings.
  • Select notifications from the left hand bar.
  • Change either Global notification level or a given group's notification level to custom
  • Click on the 'notification emails.' link
  • Help page opens stating 'This document was moved to another location'

The incorrect link is https://gitlab.com/help/workflow/notifications, the redirect is to ../user/profile/notifications.md, ie: https://gitlab.com/help/user/profile/notifications.md

Example Project

N/A

Dialogue is part of the user profile configuration, and so is not project specific.

I found it using .com.

What is the current bug behavior?

The link in the dialog goes to a redirect page, user has to click again to get the correct page.

What is the expected correct behavior?

Link goes direct to the correct page.

Relevant logs and/or screenshots

Screenshot_from_2019-11-14_14-21-15 Screenshot_from_2019-11-14_14-28-39

Output of checks

I found this bug on gitlab.com (next)

My self managed test instance is currently on 12.3.5, and the redirect isn't in place yet, so this looks like a recent change.

Results of GitLab environment info

Expand for output related to GitLab environment info 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:env:info)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Possible fixes

I think the old link is in /app/views/shared/notifications/_custom_notifications.html.haml

Edited by Ben Prescott (ex-GitLab)