To-Do List incorrectly states your list is empty when a non-matching filter is applied

Summary

The To-Do List feature incorrectly provides the message "Nothing is on your to-do list. Nice work!" when filter criteria are applied that don't match any of your to-do items. That can lead the user to incorrectly believe that they have no To-Do items. Instead of the "Nothing is on your To-Do list" message, the following should be shown:

image

This issue would be less of a problem if it was obvious when you have criteria selected. Unfortunately, the lack of contrast between a selected filter and a non-selected filter is so subtle that a user may not notice they have a filter selected.

Steps to reproduce

  1. Open your To-Do list.
  2. Apply a filter that does not match any To-Do item.

Example Project

N/A

What is the current bug behavior?

The To-Do List feature incorrectly provides the message "Nothing is on your to-do list. Nice work!" when filter criteria are applied that don't match any of your to-do items.

What is the expected correct behavior?

Instead of the "Nothing is on your To-Do list" message, the following should be shown:

image

Relevant logs and/or screenshots

See above.

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Possible fixes

Edited by Russell Dickenson