"Skip outdated deployment jobs" should skip jobs instead of failing it
Problem
This is one of the biggest issues in the Skip outdated deployment jobs feature:
Currently, when the system detected an outdated deployment job, it fails the job instead of skipping it. For example, user sees the following message in the pipeline job page:
This is very misleading that, typically failed status implies that the job was executed but not succeeded, however, in this case, the job was not executed at all. This also affects the total pipeline status that pipeline failed because of the deployment job was failed. But in reality, it was skipped thus it shouldn't mark the pipeline as failed status.
Proposal
The system skips the outdated deployment jobs. Users should see the following page in pipeline job page.
Technical details
Currently, we don't have a capability to show an additional message in a skipped job page.
This is supported in failed job page as of today, so we implement the same mechanism for the skipped job page as well. This is already bought up in #s_verify
channel.
https://gitlab.slack.com/archives/C0SFP840G/p1653386465771069
Q: We have a feature to attach failure_reason for failed jobs, which is displayed in job detail page. Do we have an issue to attach similar reasons for skipped or cancelled jobs?
I think we don’t have an issue about it. It would be nice to attach a reason in some cases. Though I think it may need to become reason since it would be for other transitions than failed.