./spec/workers/container_registry/migration/enqueuer_worker_spec.rb:405 fails on PG 11
While running a pipeline we noticed that ./spec/workers/container_registry/migration/enqueuer_worker_spec.rb:405 fails https://gitlab.com/gitlab-org/gitlab/-/jobs/2478839201. This pipeline is in Ruby 3, but after testing it locally by running GDK with PG 11, it also fails on master.
1) ContainerRegistry::Migration::EnqueuerWorker#perform with container_registry_migration_phase2_enqueuer_loop enabled when multiple aborted imports are available when an error occurs does abort that migration
Failure/Error: logger.info(structured_payload(extras))
#<Gitlab::SidekiqLogging::ClientLogger:0x00007fde27a95a80 @level=0, @progname=nil, @default_formatter=#<Logger::Formatter:0x00007fde27a95990 @datetime_format=nil>, @formatter=#<Gitlab::SidekiqLogging::JSONFormatter:0x00007fde27a2a2f8>, @logdev=#<Logger::LogDevice:0x00007fde27a958a0 @shift_period_suffix="%Y%m%d", @shift_size=1048576, @shift_age=0, @filename=#<Pathname:/builds/gitlab-org/gitlab/log/sidekiq_client.log>, @dev=#<File:/builds/gitlab-org/gitlab/log/sidekiq_client.log>, @binmode=false, @mon_data=#<Monitor:0x00007fde27a95850>, @mon_data_owner_object_id=240080>> received :info with unexpected arguments
expected: ({"class"=>"ContainerRegistry::Migration::EnqueuerWorker", "container_repository_id"=>52, "container_r...try", "jid"=>nil, "job_status"=>"running", "queue"=>"cronjob:container_registry_migration_enqueuer"})
got: ({"class"=>"ContainerRegistry::Migration::EnqueuerWorker", "container_repository_id"=>53, "container_r...try", "jid"=>nil, "job_status"=>"running", "queue"=>"cronjob:container_registry_migration_enqueuer"})
Diff:
@@ -1,7 +1,7 @@
[{"class"=>"ContainerRegistry::Migration::EnqueuerWorker",
- "container_repository_id"=>52,
+ "container_repository_id"=>53,
"container_repository_migration_state"=>"import_aborted",
- "container_repository_path"=>"namespace4/project4/test_image_4",
+ "container_repository_path"=>"namespace5/project5/test_image_5",
"correlation_id"=>"9bcf33685ccf3a6aed36a22f7bbfa914",
"import_type"=>"retry",
"jid"=>nil,
This is reproducible in GDK by:
- Running GDK with PG 11
- Running the spec
./spec/workers/container_registry/migration/enqueuer_worker_spec.rb:405