Fix skipped EE feature tests on the JH side
Related issue https://gitlab.com/gitlab-jh/gitlab-jh-enablement/-/issues/166
We made some changes to the EE and CE functionality on the JH side, so there were some tests that failed, and we skipped them before, but we didn't think that was a good idea, so we started trying to fix the failed tests, and the idea was to put different logic into helper methods, And then overwrite the method on the JH side.
For example, just like what this MR did.
JH synchronizes the image in CI template to TCR
due to network reasons, and then some CI template related tests fail. Check the cause, which is caused by the mismatch of SECURE_ANALYZERS_PREFIX
in the test. Because we modified the SECURE_ANALYZERS_PREFIX
of CI template. On JH side, SECURE_ANALYZERS_PREFIX
is the link of TCR. And originally the test expectation is registry.gitlab.com/gitlab-org/security-products/analyzers
, this will lead to test does not pass. The solution we came up with was to replace the static string with a helper method in the test, and then override the helper method on the JH side, so that running the test in JH and running the test in EE and CE will pass.
First MR !86784 (closed), but as the failed EE feature tests on the JH side involves many modules, it is divided into multiple MR to repair.
/cc @prajnamas