Links to design comments from Todos and System Notes do not jump to specific note
Summary
Links to specific design comments do not currently jump to the specific note.
This is despite the links that are generated all containing a #note_{id}
fragment portion in the href, for example: [...]/issues/1/designs/screenshot.png#note_1
.
The comment's DOM lacks the corresponding markup, so the link will never jump to the specific note when the page is loaded.
There are currently two ways that links to design comments are generated:
- When a user is mentioned in a comment on a design, the Todo will have a link to the specific comment
- When a new discussion is started on a design, a System Note on the Issue will have a link to the specific comment
The links are being generated with #note_{id}
fragment portion in them by virtue of existing GitLab service classes generating these URIs. We use similar URIs when linking to comments in issues and merge requests.
Steps to reproduce
To generate a Todo with a link to a design comment:
-
@mention
yourself in a design comment
To generate a System Note on the issue with a link to a design comment:
- Start a new discussion on a design
What is the expected correct behavior?
That the link will jump you to the specific comment.