Some identicons not readable in Dark Mode (alpha)
Summary
If a user switch the GitLab theme to "Dark Mode (alpha)", i.e. full dark mode, some text-based Project Avatars (a.k.a. identicons) have very close text color with its background.
Steps to reproduce
- Switch to Dark Mode (alpha) navigation theme
- Open Project List
- Some identicons looks like screenshot below
What is the current bug behavior?
What is the expected correct behavior?
The two identicons in the above screenshot in red rectangles should have a dark background.
Output of checks
This bug happens on GitLab.com
Possible fixes
Here are the two CSS snippets from startup-general.css
and startup-dark.css
. Out of 7 identicon backgrounds, 6 of them are correctly updated to a darker background, which would behave correctly under dark mode. But bg3
has the same #f1f1ff
color in both light and dark mode, leading to the background to have similar color as the text in dark mode.
Fix should be relatively easy, just change two .identicon.bg3
color in startup-dark.scss
two a darker hex color.
- https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/stylesheets/startup/startup-dark.scss#L1659
- https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/assets/stylesheets/startup/startup-dark.scss#L1659
Happy to open an MR for this trivial fix, but need a hint on which dark color to change to for bg3
's #f1f1ff
related: !49785 (merged)