Reduce inaccurate review requests for Manage::Auth
Objective
Reduce noisy inaccurate review requests for Manage::Auth team in code owners.
Success criteria
Manage::Auth team is not required to review MRs that are related to token changes in other areas of the product
Considerations
- Guidelines and best practices need to be documented to help scaling out to other high impact areas with &7912.
List of examples
-
!85494 (diffs)
- Disabling eslint:
app/assets/javascripts/alerts_settings/graphql/mutations/reset_http_token.mutation.graphql
- Disabling eslint:
-
!84623 (diffs)
- Disabling eslint:
app/assets/javascripts/access_tokens/components/token.vue
ee/app/assets/javascripts/audit_events/components/tokens/shared/audit_filter_token.vue
ee/app/assets/javascripts/audit_events/components/tokens/group_token.vue
ee/app/assets/javascripts/audit_events/components/tokens/member_token.vue
ee/app/assets/javascripts/audit_events/components/tokens/project_token.vue
ee/app/assets/javascripts/audit_events/components/tokens/user_token.vue
- Disabling eslint:
-
!85537 (diffs)
- These belong to ~"group::release" ref: gitlab-org/quality/engineering-productivity/team#16 (comment 922156278)
app/controllers/groups/deploy_tokens_controller.rb
app/controllers/projects/deploy_tokens_controller.rb
lib/api/deploy_tokens.rb
- These belong to ~"group::release" ref: gitlab-org/quality/engineering-productivity/team#16 (comment 922156278)
-
!85158 (diffs)
- This belongs to ~"group::release"
app/models/deploy_token.rb
- This belongs to ~"group::release"
Edited by Lin Jen-Shin