Docs - Rack Attack - "keys *rack::attack*" doesn't work as KEYS is disabled by default
Problem to solve
The Remove blocked IPs from Rack Attack via Redis documentation details step 4 as the following:
- Confirm that the key with the IP no longer shows up:
keys *rack::attack*
If someone runs these commands they see the following:
redis /var/opt/gitlab/redis/redis.socket> keys *rack::attack*
(error) ERR unknown command 'keys'
According to the renamed commands section in our Redis documentation, the KEYS command is disabled by default for security reasons.
This is not obvious to the user when they run the KEYS command.
Proposal
The Remove blocked IPs from Rack Attack via Redis documentation needs to be updated to either:
- Find another way to validate that the IP address is no longer in Redis that does not use the
KEYScommand - Add a warning to this page asking the user to temporarily enable the
KEYScommand (could point them to the renamed commands section of our Redis documentation)