Checkbox is disabled when returning to import from external repo
Summary
Mirror repository checkbox can be stuck in a disabled state.
Steps to reproduce
Use Firefox
- Create a new project/repository
- Choose Import project
- Pick Repo by URL
- Change the option to a different choice like
GitHub
- Use the back function in the browser to go back a page
- Select Repo by URL again
- The mirror repository button will be disabled
Work around. Start the process over and don't navigate away.
Example Project
N/A
What is the current bug behavior?
The checkbox is disabled when it should not be
What is the expected correct behavior?
Don't set the checkbox to disabled
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Implementation plan
Three steps to fix:
- Remove
disabled by default
behavior in /home/xanf/projects/gitlab/gdk/gitlab/ee/app/views/shared/ee/_import_form.html.haml - Remove logic which toggles
disabled
state inapp/assets/javascripts/projects/project_new.js
- Update relevant tests
Edited by Illya Klymov