Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,769
    • Issues 44,769
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,331
    • Merge requests 1,331
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #359113
Closed
Open
Issue created Apr 14, 2022 by Gabe Weaver@gweaver🌴Developer

Make it possible to handle both Mailgun's temporary and permanent failure hooks.

Problem

This is an infradev item because we had a week-long incident where e-mail notifications were delayed. We think the large number of Mailgun failures (both temporary and permanent) might have quietly induced a large build-up of retries on Mailgun's side. Usually Mailgun will add a permanent suppression to avoid affecting our sending reputation, but in this case we saw large number of temporary failures that should have caused us to stop sending notifications

Proposal

  • Make it possible to handle both Mailgun's temporary and permanent failure hooks.
  • Related code: https://gitlab.com/gitlab-org/gitlab/blob/9c8a128ea056ee9170c7a32ad28a65900ec873aa/app/services/members/mailgun/process_webhook_service.rb

Engineering breakdown

Things we'll need to do here:

  1. Redirect / alias /-/members/mailgun/permanent_failures to a more generic /-/mailgun/permanent_failures
  2. Add /-/mailgun/temporary_failures or we could just make this one endpoint to handle both if payload has data to identify if it's a temporary or permanent failure
  3. For these new endpoints, detect "invite email" failures and call Members::Mailgun::ProcessWebhookService on those. For the other failures, we will handle them in the next issue
Edited May 10, 2022 by Gabe Weaver
Assignee
Assign to
Time tracking