Follow-up from "Move Alerts metric image API to CE"
The following discussion from !84918 (merged) should be addressed:
-
@mikolaj_wawrzyniak started a discussion: (+1 comment) nitpick (non-blocking): Have you considered using
let_it_be
for common test set up, following https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#common-test-setup Right now it will not bring real improvement because there is only one test case in this context, but it might yield gains if anyone decided to add new test in the future.let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project) } let_it_be(:alert) { create(:alert_management_alert, project: project) } let_it_be(:metric_image) { create(:alert_metric_image, alert: alert) } before_all do project.add_developer(user) sign_in(user) end