Skip to content

Only tasks should open up in a modal and other work item routing bugs

Grouping these under the same issue to make collaboration / visibility easier.

Bug 1 (Resolved)

When creating a new work item by converting a markdown checklist item to a work item, selecting any type other than Task (ex: Issue), creating the work item, then subsequently clicking on the newly created work item of type issue from the description, it opens up in a modal and not in the issue detail view.

This also applies to all referenced work items from within a description, whether the reference was automatically added by creating a new work item or simply typing #.... (ex: click on the "Issue work item" from the description here -- https://gitlab.com/gitlab-org/plan-stage/test-project/-/issues/83)

Bug 2 (Resolved)

When clicking on a related work item of type Task from the Linked issues widget, it opens up to a full issue detail view / route. (ex: click on Task work item from the widget here -- https://gitlab.com/gitlab-org/plan-stage/test-project/-/issues/83)

Bug 3

When clicking on a work item of type Task from a user's profile activity feed, it opens up at the /issues/ route and not the work item route. Gabe's sidenote: This makes me concerned that solving this will be a widespread problem across the entire product with lots of fringe cases and locations we won't realize need updating until something breaks.

Expected behavior

  1. Only work item type of Task should open up in a modal when being clicked on from within an issue detail view -- whether from a reference in a description or comment, or via the Linked issues widget.
  2. All other work item types should take the user to the issue detail view and the /issues/ route.
  3. When clicking on a work item of type Task from anywhere else outside of the issue detail view, it should be opened at the canonical path for the Task -- /work_items/...

Considerations

  1. What route we use right now is not nearly as important as always conditionally loading the new work item vue app when viewing a task and loading all other work item types in the legacy issue/requirements/... views/routes.
Edited by Gabe Weaver