Transient failure in qa/specs/features/ee/browser_ui/3_create/merge_request/add_batch_comments_in_merge_request_spec.rb
https://gitlab.com/gitlab-org/gitlab-qa/-/jobs/343994032
1) Create batch comments in merge request user submits, discards batch comments
Failure/Error: expect(show).to have_content("2/2 threads resolved")
expected to find text "2/2 threads resolved" in "Skip to content Projects Groups More 2 2 P project-with-merge-request-fa558c37b805f662 Project overview Repository Issues 0 Merge Requests 1 CI / CD Security & Compliance Operations Packages Wiki Snippets Settings Collapse sidebar gitlab-qa-sandbox-group qa-test-2019-11-07-04-06-17-a1409581e4fc35f6 project-with-merge-request-fa558c37b805f662 Merge Requests !1 Open Opened just now by Administrator Edit Close merge request This is a merge request Great feature Request to merge qa-test-feature-4b984fa5d8cfa631 into master Open in Web IDE Check out branch Pipeline #10 pending for 7b05e907 on qa-test-feature-4b984fa5d8cfa631 No approval required Merge when pipeline succeeds Delete source branch 1 commit and 1 merge commit will be added to master. Modify merge commit You can merge this merge request manually using the command line 0 0 Discussion 5 Commits 1 Pipelines 1 Changes 1 0/2 threads resolved Changes between latest version and master 1 File 1 0 added_file.txt 1 0 File Added Administrator @root · just now Owner Can you check this line of code? Collapse replies Administrator @root · just now Owner And this syntax as well? Pending Administrator @root · And this syntax as well? Finish review 2 drafts Add comment now Start a new discussion... \\ No newline at end of file To Do Add a To Do 0 Assignees Edit None - assign yourself Milestone Edit None Time tracking No estimate or time spent Labels Edit None Lock merge request Edit Unlocked 1 participant Notifications Reference: gitlab-qa-sandbox-group/qa-test-2019-11-07-04-06-17-a1409581e4fc35f6/project-with-merge-request-fa558c37b805f662!1 Finish review 2 drafts 2 pending comments Administrator's thread Could you also check that? Thread will be resolved added_file.txt :1 And this syntax as well? Thread will be resolved Submit review Discard review"
# ./qa/specs/features/ee/browser_ui/3_create/merge_request/add_batch_comments_in_merge_request_spec.rb:55:in `block (4 levels) in <module:QA>'
# ./qa/scenario/actable.rb:16:in `perform'
# ./qa/specs/features/ee/browser_ui/3_create/merge_request/add_batch_comments_in_merge_request_spec.rb:25:in `block (3 levels) in <module:QA>'
1st attempt logs show:
D, [2019-11-07T04:09:16.898570 #24] DEBUG -- : clicking :diffs_tab with args {}
D, [2019-11-07T04:09:16.898700 #24] DEBUG -- : finding :diffs_tab with args {:text=>nil}
D, [2019-11-07T04:09:16.929709 #24] DEBUG -- : found :diffs_tab
D, [2019-11-07T04:09:17.013407 #24] DEBUG -- : next wait uses reload: true
D, [2019-11-07T04:09:17.013530 #24] DEBUG -- : with wait: max 60; interval 5
D, [2019-11-07T04:09:17.964008 #24] DEBUG -- : has_text?('No newline at end of file') returned true
D, [2019-11-07T04:09:17.964116 #24] DEBUG -- : ended wait after 0.950529021 seconds
D, [2019-11-07T04:09:17.964196 #24] DEBUG -- : finding all :new_diff_line
D, [2019-11-07T04:09:18.004008 #24] DEBUG -- : found 2 :new_diff_line
D, [2019-11-07T04:09:18.268453 #24] DEBUG -- : clicking :diff_comment with args {}
D, [2019-11-07T04:09:18.268567 #24] DEBUG -- : finding :diff_comment with args {:text=>nil}
D, [2019-11-07T04:09:18.309364 #24] DEBUG -- : found :diff_comment
D, [2019-11-07T04:09:18.441686 #24] DEBUG -- : filling :reply_input with "Can you check this line of code?"
D, [2019-11-07T04:09:18.443258 #24] DEBUG -- : finding :reply_input with args {}
D, [2019-11-07T04:09:18.480969 #24] DEBUG -- : found :reply_input
D, [2019-11-07T04:09:18.842756 #24] DEBUG -- : clicking :comment_now with args {}
D, [2019-11-07T04:09:18.843159 #24] DEBUG -- : finding :comment_now with args {:text=>nil}
D, [2019-11-07T04:09:18.876668 #24] DEBUG -- : found :comment_now
1st Try error in ./qa/specs/features/ee/browser_ui/3_create/merge_request/add_batch_comments_in_merge_request_spec.rb:19:
expected to find text "Can you check this line of code?" in "Skip to content Projects Groups More 2 2 P project-with-merge-request-adde7f86236920c6 Project overview Repository Issues 0 Merge Requests 1 CI / CD Security & Compliance Operations Packages Wiki Snippets Settings Collapse sidebar gitlab-qa-sandbox-group qa-test-2019-11-07-04-06-17-a1409581e4fc35f6 project-with-merge-request-adde7f86236920c6 Merge Requests !1 Open Opened just now by Administrator Edit Close merge request This is a merge request Great feature Request to merge qa-test-feature-c67f243f949eea77 into master Open in Web IDE Check out branch Pipeline #8 pending for 1165982d on qa-test-feature-c67f243f949eea77 No approval required Merge when pipeline succeeds Delete source branch 1 commit and 1 merge commit will be added to master. Modify merge commit You can merge this merge request manually using the command line 0 0 Discussion 2 Commits 1 Pipelines 1 Changes 1 0/1 thread resolved Changes between latest version and master 1 File 1 0 added_file.txt 1 0 File Added Write Preview Markdown is supported Attach a file Add to review Add comment now Cancel \\ No newline at end of file To Do Add a To Do 0 Assignees Edit None - assign yourself Milestone Edit None Time tracking No estimate or time spent Labels Edit None Lock merge request Edit Unlocked 1 participant Notifications Reference: gitlab-qa-sandbox-group/qa-test-2019-11-07-04-06-17-a1409581e4fc35f6/project-with-merge-request-adde7f86236920c6!1 Finish review 1 draft Discard review New! Suggest changes directly Suggest code changes which are immediately applied. Try it out! Got it"
The text is clearly visible in the screenshot, so I don't know why it failed.
2nd attempt shows:
D, [2019-11-07T04:10:08.932226 #24] DEBUG -- : filling :reply_input with "And this syntax as well?"
D, [2019-11-07T04:10:08.933114 #24] DEBUG -- : finding :reply_input with args {}
D, [2019-11-07T04:10:09.009563 #24] DEBUG -- : found :reply_input
D, [2019-11-07T04:10:09.432308 #24] DEBUG -- : scrolling to :[data-qa-selector="start_review"],.qa-start-review
D, [2019-11-07T04:10:09.439159 #24] DEBUG -- : finding :resolve_review_discussion_checkbox with args {}
D, [2019-11-07T04:10:09.462889 #24] DEBUG -- : found :resolve_review_discussion_checkbox
D, [2019-11-07T04:10:09.549057 #24] DEBUG -- : clicking :start_review with args {}
D, [2019-11-07T04:10:09.550249 #24] DEBUG -- : finding :start_review with args {:text=>nil}
D, [2019-11-07T04:10:09.581543 #24] DEBUG -- : found :start_review
D, [2019-11-07T04:10:11.352510 #24] DEBUG -- : within element :review_bar
D, [2019-11-07T04:10:11.381007 #24] DEBUG -- : clicking :review_preview_toggle with args {}
D, [2019-11-07T04:10:11.381217 #24] DEBUG -- : finding :review_preview_toggle with args {:text=>nil}
D, [2019-11-07T04:10:11.408037 #24] DEBUG -- : found :review_preview_toggle
D, [2019-11-07T04:10:11.464478 #24] DEBUG -- : clicking :submit_review with args {}
D, [2019-11-07T04:10:11.464595 #24] DEBUG -- : finding :submit_review with args {:text=>nil}
D, [2019-11-07T04:10:11.498220 #24] DEBUG -- : found :submit_review
D, [2019-11-07T04:10:11.592262 #24] DEBUG -- : end within element :review_bar
user submits, discards batch comments (FAILED - 1)
Again, the screenshot clearly shows the expected text (2/2 threads resolved
)