Skip to content

AuditEventStreamingWorker enqueued for all groups regardless of destinations

Overview

  • We noticed a spike in the sidekiq queues for AuditEventStreamingWorker including for gitlab-org which does not utilize audit event streaming.
  • It was determined that a worker was enqueued for every streamable audit event for every ultimate namespace and then immediately completed when evaluating group.external_audit_event_destinations was evaluated.

Proposal

  • Add a guard clause before the job is enqueued in EE::AuditEvent#L57 to avoid enqueuing essentially pointless jobs.