Automated attention requests are confusing and hard to understand what is happening
Problem to Solve
The automated behaviors of attention requests can cause confusion or undesirable situations in who's attention is requested. These behaviors are further compounded by the lack of real-time feedback or notice within the application that something has happened and attention changes have occurred.
Proposal
- Remove the automatic behavior of requesting the attention of the current user when they add themselves as an assignee or reviewer.
- Keep all the other automated behaviors that remove one's attention request.
- For the other automated behaviors, add new toasts or extend existing toasts to communicate the automated behavior. These messages are only shown if the current user has an attention request.
- Approve the merge request:
Approved. Your attention request was removed.
- Add a new user as an assignee:
Assigned user(s). Your attention request was removed.
- Bonus points if we can get the usernames in there
😄
- Bonus points if we can get the usernames in there
- Add a new user as a reviewer:
Requested review. Your attention request was removed.
- Request the attention of a different assignee or reviewer:
Requested attention from @%{username}. Your own attention request was removed.
- Multiple actions performed using quick actions: append
Your attention request was removed.
to the info alert message that appears when quick actions are performed.
- Approve the merge request:
Original Description
## Problem to SolveIf I am a reviewer and need to request attention from both myself and another reviewer, I'm unable to do so because requesting attention from another user clears the attention request from myself.
From @pslaughter (#356696 (comment 886135674))
Hmmm.... As a MR coach, I'm often a reviewer and requesting reviews from BE, Database, etc. on behalf of the contributor. It would be confusing to me if assigning a reviewer automatically removed the "attention request" before I actually finished my review.
suggestion: I'm not sure how flexible these rules are, but it might be preferable to lean towards forcing users to be more explicit (rather than figure it out for them) when attention is removed
🤷 IMHO, I think it makes sense to automatically remove the attention only when:
- Approve the merge request.
- Remove yourself (or are removed by someone else) as an assignee or reviewer.
- Merge or close the merge request.
Otherwise, let's force users to explicitly remove the attention and not risk causing confusion.
Proposal
We should consider if this is desired behavior, unique situation or something worth fixing.