Add consideration for application limits to the default MR template
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Overview
In order to improve the availability of GitLab.com, we've been prioritizing improvements that set limits throughout the application.
This is great, but we should also take steps to prevent new features from being merged that don't have limits - ideally, we should prevent this from being a problem in the first place, by making sure that new MRs are thoughtfully considering application limits.
Proposal
Add the following checkbox to the default MR template to the Availability and Testing section:
- [ ] Considered opportunities for application limits to protect performance (timeouts, size/length limits, etc.)
For reference, the proposed Availability and Testing section of the MR template would look like:
### Availability and Testing
<!-- What risks does this change pose? How might it affect the quality/performance of the product?
What additional test coverage or changes to tests will be needed?
Will it require cross-browser testing?
See the test engineering process for further guidelines: https://about.gitlab.com/handbook/engineering/quality/test-engineering/ -->
<!-- If cross-browser testing is not required, please remove the relevant item, or mark it as not needed: [-] -->
- [ ] [Review and add/update tests for this feature/bug](https://docs.gitlab.com/ee/development/testing_guide/index.html). Consider [all test levels](https://docs.gitlab.com/ee/development/testing_guide/testing_levels.html). See the [Test Planning Process](https://about.gitlab.com/handbook/engineering/quality/test-engineering).
- [ ] [Tested in all supported browsers](https://docs.gitlab.com/ee/install/requirements.html#supported-web-browsers)
- [ ] Considered opportunities for application limits to protect performance (timeouts, size/length limits, etc.)