Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,769
    • Issues 44,769
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,331
    • Merge requests 1,331
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #355708
You need to sign in or sign up before continuing.
Closed
Open
Issue created Mar 14, 2022 by Shinya Maeda@shinya.maeda💡Maintainer

Support Approval Rules in Deployment Approval UI

Problem

In the initial MVC, both Deployment Executors and Deployment Approvers were managed in the same access level. This could be a problem that Approvers can accidentally gain an access to the critical environment, where they are supposed to approve/reject only. To resolve the problem, we should separate access levels between executors and approvers. For example:

  • Production Environment:
    • Who can deploy?: @operator-group
    • Needs approval for deployment?:
      • At least one approval from @qa-tester-group
      • At least one approval from @security-group

In the previous issue, we added a API-basis support for the Multi Access Levels. In this issue, we extend the feature to frontend part, so that users can easily interact with the multi access levels.

Design

  • Add in table with approvers, approvals, approved by to give those viewing the modal the appropriate information and history behind who has approved, and who still needs to approve.
  • Not in scope for this issue: Cleaning up the comments section will be done in Enhance comment section in Deployment Approval ... (#372377)
New Modal
Screen_Shot_2022-09-01_at_10.26.16_AM
  • Note: The Modal is getting busy! Moving information out of the modal will be handled in: Deployment Detail Page (#360503)
  • Modal with all variations can be found here.

Figma File

This page may contain information related to upcoming products, features and functionality. It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes. Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.

Edited Sep 01, 2022 by Emily Bauman
Assignee
Assign to
Time tracking