Scan Result policy number of allowed vulnerabilities is misleading
Summary
Currently the rule mode text says "finds x
**or more ** vulnerabilities". The yaml mode variable of vulnerabilities_allowed
does not match this.
We need to do one of these two solutions:
-
Possible solution 1 We need to change the
vulnerabilities_allowed
value to be one less than thex
or more rule mode value. For example, if1
is entered in the rule mode, then0
should be the value displayed in yaml mode. Also we should change the default rule mode value to be 1 instead of 0. -
Possible solution 2 We could change the wording of the rule mode to say "finds more than
x
vulnerabilities" so that the number in rule mode and yaml mode can match.
Steps to reproduce
Example Project
What is the current bug behavior?
What is the expected correct behavior?
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)