Skip to content

Follow-up from "Resolve "Bug: When using the /merge quick action, it returns 'Merged' even though it was not""

The following discussion from !82170 (merged) should be addressed:

  • @marc_shaw started a discussion: (+2 comments)

    @patrickbajao @kerrizor

    Could I have some input here? When do we use mergeable_state, versus mergeable?

    Why is it a bad idea to change this to mergeable? - I see it will make this more costly to run. Instead could we move the ee checks in the mergeable method to mergeable_state, since mergeable calls mergeable_state anyway? And keep this checking mergeable_state method?

Edited by Marc Shaw