Allow users to remove a deployment approval
Problem
Deployment Approvals is a feature to cross-verify the upcoming deployments whether it's safe to be proceeded/promoted. The users who are allowed to approve an deployment can choose a action from the following:
- Approve ... Approve a deployment. The deployment job will run if sufficient approvals have been collected.
- Reject ... Reject a deployment. The deployment job immediately fails to halt the unwanted deployment.
However, we're lacking an action for removing an approval. For example, A user who has already approved can change their mind to take the previous decision back and do a further investigation, instead of immediately rejecting it. In fact, MR approvals already support this capability and it's important piece of the feature.
Insights from Environment Management CMS
This issue also surfaced during the CMS interviews for Environment Management. Participants made a comment that they didn’t like the idea that an approval was permanent with no options to edit, and there was no way to revoke an approval like you could in an MR. Ideally a deployment approval would follow the same flow as an MR approval, such as if something changes it can easily be revoked.
Supporting evidence
Proposal
Allow users to remove a deployment approval