Add a new delayed_group_deletion application setting
Problem to solve
As part of &7568 (closed) we want to enable administrators to disable group & project delayed deletion without setting deletion_adjourned_period to 0 and thus overriding the user's choice. Currently the only way to disabled delayed deletion.
For additional context please view the frontend issue #352960 (closed).
Proposal
Add a new application / instance setting to enable / disable group delayed deletion.
Implementation plan
backend estimated weight of
- Add a new instance setting for
delayed_group_deletion(defaulttrue) that is seperate fromdelayed_project_deletion. This is needed becausedeletion_adjourned_periodshould only be greater than1and thus no longer be used to check if delayed group deletion should be enabled / disabled. We also don't want to override the user specifieddeletion_adjourned_periodeven when the user opted toNone, delete immediately. Additional context #348332 (comment 840063606). - Add a migration plan to set the value of
delayed_group_deletiontodeletion_adjourned_period > 0. - When
deletion_adjourned_periodis set, also set thedelayed_group_deletiontodeletion_adjourned_period > 0. - Update the Remove group button under Group > Advanced Settings to only show the delayed deletion message and modal when both
delayed_group_deletionistrueanddeletion_adjourned_periodis>0. Currently group delayed deletion only depends ondeletion_adjourned_period > 0. - Update the applications settings API doc to add
delayed_group_deletionsetting.
Edited by Jiaan Louw