Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,761
    • Issues 44,761
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,332
    • Merge requests 1,332
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #352959
Closed
Open
Issue created Feb 16, 2022 by Jiaan Louw@jiaan2️⃣Maintainer0 of 5 checklist items completed0/5 checklist items

Add a new `delayed_group_deletion` application setting

Problem to solve

As part of &7568 we want to enable administrators to disable group & project delayed deletion without setting deletion_adjourned_period to 0 and thus overriding the user's choice. Currently the only way to disabled delayed deletion.

For additional context please view the frontend issue #352960 (closed).

Proposal

Add a new application / instance setting to enable / disable group delayed deletion.

Implementation plan

backend estimated weight of 2️⃣ / 3️⃣

  1. Add a new instance setting for delayed_group_deletion (default true) that is seperate from delayed_project_deletion. This is needed because deletion_adjourned_period should only be greater than 1 and thus no longer be used to check if delayed group deletion should be enabled / disabled. We also don't want to override the user specified deletion_adjourned_period even when the user opted to None, delete immediately. Additional context #348332 (comment 840063606).
  2. Add a migration plan to set the value of delayed_group_deletion to deletion_adjourned_period > 0.
  3. When deletion_adjourned_period is set, also set the delayed_group_deletion to deletion_adjourned_period > 0.
  4. Update the Remove group button under Group > Advanced Settings to only show the delayed deletion message and modal when both delayed_group_deletion is true and deletion_adjourned_period is >0. Currently group delayed deletion only depends on deletion_adjourned_period > 0.
  5. Update the applications settings API doc to add delayed_group_deletion setting.
Edited Feb 16, 2022 by Jiaan Louw
Assignee
Assign to
Time tracking