Skip to content

馃帹 Design Follow-up: Investigate validation of required approvals to avoid dead-end-rules

The following discussion from !80221 (merged) should be addressed:

@jannik_lehmann started a discussion: (+4 comments)

Question: This might be out of scope but when playing around with this feature I noticed that I can define the number of approvals needed and I can add Users and/or Groups as reviewers. Especially when Groups are coming in here I could see this having the potential for our users to build a "dead-end-rule" Which would be requiring 5 approvals and assigning a group of 4 as reviewers. Or what if the groupsize changes 馃? I was wondering if this question is being thought about and if we would maybe could warn the user in such a case about this?

@sam.white @jannik_lehmann @andyvolpe this is a great use case that we have not considered. Would it be ok if we follow this up in a separate issue? I don't see this as a blocker for releasing this; although, it is something that we should do from a user experience perspective. Note: This is already a problem with the current Vulnerability-check implementation, so we aren't really introducing any new experience issues here. Also, we will never really be able to fully protect against this since someone could require approval from 5 users from a group that has 6 members in it and then afterwards they could go in and remove 2 of those members from the group - leading to the same problem.

Edited by Sam White